Issue 66665 - OOo m172 crash when open a file with password and input not right password
Summary: OOo m172 crash when open a file with password and input not right password
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: open-import (show other issues)
Version: OOo 2.0.3
Hardware: PC Linux, all
: P3 Trivial with 2 votes (vote)
Target Milestone: OOo 2.0.4
Assignee: wolframgarten
QA Contact: issues@graphics
URL:
Keywords: crash
Depends on:
Blocks:
 
Reported: 2006-06-23 01:50 UTC by jlcheng
Modified: 2006-08-03 10:21 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description jlcheng 2006-06-23 01:50:11 UTC
Steps to replicate:

1) Start a complete new impress(not from already existed soffice).
2) From wizard, select "Open existing presentation" and you select a file with
password, then you input incorrect password. You can get a "Read-Error" dialog,
then click "OK", and OOo crash. Only Linux is crash, Windows 2000 is better and
you can get an application frame.
Comment 1 wolframgarten 2006-06-23 08:05:56 UTC
The crash is not reproducible but I get the empty frame without a menu bar.
Comment 2 jlcheng 2006-06-23 08:11:33 UTC
Yes, if you from an already existed soffice, you can get an empty frame. If you
close whole application, then from simpress.bin to open the file, you can get crash.
Comment 3 wolframgarten 2006-06-23 08:14:50 UTC
No, sorry, even then I get an empty frame. Starting ./simpress, select open
existing file, select file, insert wrong pasword, clicking ok, frame is empty.
Do you get the crashreporter?
Comment 4 jlcheng 2006-06-23 08:25:59 UTC
I use debian and can not get crash report at all.
Comment 5 wolframgarten 2006-06-23 08:38:55 UTC
Wait a minute: is the version you are using  build by debian? Then of course the
problem should be reported to Debian, we can do nothing about it here, it is
their build.
Comment 7 jlcheng 2006-06-23 09:01:11 UTC
Yes. I think this is "OpenOffice.org Developer" build.
Comment 8 clippka 2006-06-23 14:02:36 UTC
@cl->af: please have a look at this. I already tested if this is again a
situation where we have an exception during loading inside the wizard but I
couldn't verify that. But at least the behaviour with the password error is weird
Comment 9 groucho266 2006-06-23 15:03:24 UTC
Accepted.
Comment 10 pavel 2006-06-23 20:46:36 UTC
pjanik: please have a look, try to replicate, show gdb stack.
Comment 11 pavel 2006-06-23 21:05:50 UTC
1. I create the presentation /tmp/with_password_password.odp (attached).

2. soffice -impress, Open existing presentation, fin this presentation.

Even without entering any password! it tells me:

Error loading the template : (notice SPACE before :!)
Read Error.
The wrong password has been entered.

It works for non-password protected presentations.
The same from already running soffice.

No crash.
Comment 12 jlcheng 2006-06-27 01:51:26 UTC
I have found another crash occation.
1) have a odp documnet with password (eg ps.odp)
2) print the command line: #./soffice.bin  /yourdir/ps.odp
3) input either a wrong password or no password
==>
the application crashed with out any report or signal.
and I am using the debian linux and also,someone has tried redhat linux and crash.
Comment 13 wolframgarten 2006-06-27 09:59:11 UTC
The last step by step description is also reproducible under Windows.
Comment 14 pavel 2006-06-27 10:04:30 UTC
change target, add crash keyword.
Comment 15 groucho266 2006-07-04 12:40:13 UTC
I can reproduce the original crash (select password protected file in wizard and
click OK) under Windows XP, too.  More about that below.

The second problem (start Office with the name of a password protected file as
argument) is not a crash.  When the wrong password is entered the Impress
recognizes the file as not being loadable and terminates.  The same happens with
invalid file names or names of not existing files.

Now to the original crash.  The problem here is that the frame is destroyed when
the document can not be loaded.  This happens when from
SdModule::ExecuteNewDocument() the SfxFrame::LoadDocumentSynchron() method is
called.  The frame that is being called is destroyed during this call.  This
causes problems both in SD and SFX2.

In SD we have to checking the result returned by LoadDocumentSynchron() and set
the pFrame pointer (that is returned by ExecuteNewDocument()) to NULL. 
Furthermore the return value of the SfxRequest has to be set to SfxBoolItem(
,FALSE).

See the next comment for the problems in SFX2.
Comment 16 groucho266 2006-07-04 12:47:24 UTC
(continued from the previous comment)
In SFX2 there the SfxFrameLoader_Impl::load() method has a problem with the
frame being destroyed in the middle of the ExecuteSlot() call in line 407, rev.
1.84.  When the loading fails it tries to release the frame.  This leads to a
crash because the frame has already been destroyed.

->MB: please have a look at this crash in SFX2.
Comment 17 Mathias_Bauer 2006-07-10 17:19:38 UTC
Whatever makes the loading fail (wrong password or something else) will cause
this crash
Comment 18 Mathias_Bauer 2006-07-21 11:30:08 UTC
please verify
Comment 19 wolframgarten 2006-07-26 08:34:04 UTC
Verified in CWS.
Comment 20 wolframgarten 2006-08-03 10:21:09 UTC
Tested in master m180. Closed.